Skip to content

Conversation

@esrakartalOpt
Copy link
Contributor

@esrakartalOpt esrakartalOpt commented Oct 30, 2025

Summary

  • Parsing the holdout section from the datafile
  • Update ProjectConfig to establish the flag's dependency on holdouts

Test plan

PR check

Issues

Copy link
Contributor

@pvcraven pvcraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for adding in holdouts. Don't see any issues.

Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mat001 Mat001 requested a review from muzahidul-opti October 31, 2025 21:44
@esrakartalOpt esrakartalOpt merged commit 9b4af2f into master Nov 3, 2025
79 of 84 checks passed
@esrakartalOpt esrakartalOpt deleted the esra/FSSDK-11569_11570_holdout_project_config branch November 3, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants